feat!: drain/needsDrain accounts for task queue #872
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
jdmarshall
reviewed
Aug 5, 2025
| const ee = new EventEmitter(); | ||
| const task1 = pool.run(bufs[0]); | ||
| const abortable = pool.run(bufs[1], { signal: ee }); | ||
| assert.strictEqual(pool.queueSize, 0); // Means it's running |
There was a problem hiding this comment.
I have a PR against p-limit to reduce the nextTick depth by one and the confirmation that something was off was found in the tests, which were asserting similarly weird numbers for queue length. I just inverted a counter and queue manipulation to eliminate the nextTick call. Ans then had to fix the tests similarly.
|
@metcoder95 Hi again! glad to see this PR is merged! i checked the npm and yet the last publish was two months, is this PR published or just merged? |
Member
Author
|
Haven't prepared yet the cut-off for the new v6; sadly this is a breaking change so cannot land on current stable :( Unless done through an flag, which can be an option. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #868