Skip to content

Conversation

@ddelange
Copy link
Collaborator

@ddelange ddelange commented Oct 30, 2025

Please pick a concise, informative and complete title for your PR.

The title is important because it will appear in our change log.

Motivation

Please explain the motivation behind this PR.

If you're fixing a bug, link to the issue using a supported keyword like "Fixes #{issue_number}".

If you're adding a new feature, then consider opening a ticket and discussing it with the maintainers before you actually do the hard work.

Fixes #900, also fixes some CI rot introduced by googleapis/python-api-core#832 (comment)

Tests

If you're fixing a bug, consider test-driven development:

  1. Create a unit test that demonstrates the bug. The test should fail.
  2. Implement your bug fix.
  3. The test you created should now pass.

If you're implementing a new feature, include unit tests for it.

Make sure all existing unit tests pass.
You can run them locally using:

pytest tests

If there are any failures, please fix them before creating the PR (or mark it as WIP, see below).

Work in progress

If you're still working on your PR, mark the PR as draft PR.

We'll skip reviewing it for the time being.

Once it's ready, mark the PR as "ready for review", and ping one of the maintainers (e.g. mpenkov).

Checklist

Before you mark the PR as "ready for review", please make sure you have:

  • Picked a concise, informative and complete title
  • Clearly explained the motivation behind the PR
  • Linked to any existing issues that your PR will be solving
  • Included tests for any new functionality
  • Run python update_helptext.py in case there are API changes
  • Checked that all unit tests pass

Workflow

Please avoid rebasing and force-pushing to the branch of the PR once a review is in progress.

Rebasing can make your commits look a bit cleaner, but it also makes life more difficult from the reviewer, because they are no longer able to distinguish between code that has already been reviewed, and unreviewed code.

@ddelange ddelange force-pushed the defer_seek branch 3 times, most recently from 19cebc5 to e99dffb Compare October 30, 2025 20:14
@ddelange ddelange force-pushed the defer_seek branch 2 times, most recently from e481ed8 to 66af06a Compare October 30, 2025 20:38
@ddelange ddelange marked this pull request as ready for review October 30, 2025 20:56
@ddelange ddelange merged commit 12f358d into develop Oct 30, 2025
6 checks passed
@ddelange ddelange deleted the defer_seek branch October 30, 2025 20:57
ddelange added a commit that referenced this pull request Oct 30, 2025
* develop:
  Update CHANGELOG.md
  Add test for seek to end + defer_seek (#901)
@github-actions
Copy link

Released v7.4.2

@ddelange ddelange mentioned this pull request Oct 31, 2025
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[s3] passing defer_seek=True breaks PyArrow read

2 participants