feat(s3): ✨ promote S3 adapter to public API#43
Merged
Conversation
- Move internal/s3 → lode/s3 (public package) - Update all imports across repo - Remove "experimental" language from docs - Add S3 section to PUBLIC_API.md with usage examples - Add "Supported Backends" section to README.md - Update docs/ARCH_INDEX.md to reflect new location - Update Taskfile.yaml for new test paths Contract compliance verified against CONTRACT_STORAGE.md: - Put: Atomic immutability via If-None-Match - Get/Exists/Delete: Standard ErrNotFound semantics - List: Full pagination, all matching keys returned - ReadRange: True HTTP Range reads, all bounds checked - ReaderAt: Concurrent-safe random access Supported backends: AWS S3, MinIO, LocalStack, Cloudflare R2
- Remove exported ClientConfig, NewClient, NewLocalStackClient, NewMinIOClient, NewR2Client from public API - Add internal helpers in integration_test.go for test-only use - Add detailed provider-specific examples to PUBLIC_API.md (AWS S3, LocalStack, MinIO, Cloudflare R2) - Update s3_experimental example to use AWS SDK directly - Update IMPLEMENTATION_PLAN.md to reflect S3 promotion status Addresses review finding: public API expansion beyond agreed direction. Client construction remains the caller's responsibility using AWS SDK.
justapithecus
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contract compliance verified against CONTRACT_STORAGE.md:
Supported backends: AWS S3, MinIO, LocalStack, Cloudflare R2