Skip to content

Enhance Cow Selection with 'f' Prefix for Custom Cow Faces#91

Open
Harishgouda06022004 wants to merge 1 commit intopiuccio:masterfrom
Harishgouda06022004:master
Open

Enhance Cow Selection with 'f' Prefix for Custom Cow Faces#91
Harishgouda06022004 wants to merge 1 commit intopiuccio:masterfrom
Harishgouda06022004:master

Conversation

@Harishgouda06022004
Copy link

Pull Request Description
This pull request adds a new f option in the index.js file to allow users to select a cow directly from the cows folder.

  • Updated README.md with examples showcasing the f option.
  • Enhanced index.js with clear documentation for all options.
  • Ensured backward compatibility by retaining existing options and functionality.
    *This pull request introduces an enhancement for selecting cow names from the cow folder within the cowsay package. Previously, the syntax used for selecting a specific cow face relied on the format cow:squirrel. However, to align with the updated functionality in the index.js file, the selection format has been modified to use the f prefix (e.g., f:squirrel).
    Key Changes:
    1:Updated the example code to reflect the new f prefix usage:
    import { think, SQUIRREL } from 'cowsay';

console.log(think({
text: 'grazing in the browser',
f: SQUIRREL, // Use f for cow name selection from the cow folder
eyes: 'pp',
tongue: ';;',
}));
2:Highlighted the transition in comments for clarity and backward compatibility.

Justification:
This change ensures that the functionality for selecting custom cow faces aligns with the current implementation of the cowsay package. It provides better clarity for developers accessing cow faces from the cow folder, making the syntax intuitive and consistent.

Impact:
*Enhances usability and compatibility with the updated codebase.
*Improves developer experience by aligning documentation and examples with current functionality.

Notes:
Please review and merge this pull request to ensure examples and documentation remain consistent with the latest implementation.

@Harishgouda06022004
Copy link
Author

This pull request introduces a change to the cowsay package, specifically adding support for selecting cow faces from the cows folder using the f prefix instead of the previous cow: format. This change improves clarity and consistency in the usage of the package.
Key Changes:
*Updated index.js to include the f option for selecting cows directly from the cows folder.
*Updated README.md with examples showing the new syntax.
*Ensured backward compatibility with the existing functionality.
I’ve tested the changes locally, and everything appears to be functioning as expected. Please feel free to review and provide any feedback.

Looking forward to your thoughts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant