Skip to content

feat: Updated kiln carvel command to include -pkg suffix to bosh release names - #669

Merged
ram-pivot merged 3 commits into
mainfrom
TNZ-119962-carvel-bosh-name
Jul 29, 2026
Merged

feat: Updated kiln carvel command to include -pkg suffix to bosh release names#669
ram-pivot merged 3 commits into
mainfrom
TNZ-119962-carvel-bosh-name

Conversation

@ram-pivot

Copy link
Copy Markdown
Contributor

ai-assisted=yes
JIRA-ID: 119962

Authored-by: Ramkumar Vengadakrishnan ramkumar.vengadakrishnan@broadcom.com

…elease name

ai-assisted=yes
JIRA-ID: 119962

Authored-by: Ramkumar Vengadakrishnan <ramkumar.vengadakrishnan@broadcom.com>

@notrepo05 notrepo05 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a couple of minor nits, but overall this looks good. Thanks!

It might be worth considering having carvel-rebake enforce that the kiln version is the same one as recorded in the bake record, since it'll make this breaking change easier mitigate / more intuitive.

Comment thread internal/carvel/baker.go Outdated
Comment thread internal/carvel/baker.go
@ram-pivot

Copy link
Copy Markdown
Contributor Author

I have a couple of minor nits, but overall this looks good. Thanks!

It might be worth considering having carvel-rebake enforce that the kiln version is the same one as recorded in the bake record, since it'll make this breaking change easier mitigate / more intuitive.

Thanks for the review. Interestingly kiln carvel publish does not write the kiln version. I fixed that and also added the kiln version check

https://github.gwd.broadcom.net/TNZ/tac-helm-cf-tile/blob/main/applications/strimzi/tile/bake_records/10.4.3.json

- Also noticed that kiln version is not currently added to kiln carvel
  baked record. Fixed that

ai-assisted=yes
JIRA-ID: TNZ-119962

Authored-by: Ramkumar Vengadakrishnan <ramkumar.vengadakrishnan@broadcom.com>
@ram-pivot
ram-pivot force-pushed the TNZ-119962-carvel-bosh-name branch from 147ad58 to af7756e Compare July 27, 2026 20:25
@ram-pivot
ram-pivot requested a review from drich10 July 29, 2026 15:26
@ram-pivot
ram-pivot merged commit b65d2d5 into main Jul 29, 2026
6 checks passed
@ram-pivot
ram-pivot deleted the TNZ-119962-carvel-bosh-name branch July 29, 2026 19:23
ram-pivot added a commit that referenced this pull request Jul 29, 2026
…ase names (#669)

ai-assisted=yes
JIRA-ID: 119962

Authored-by: Ramkumar Vengadakrishnan
<ramkumar.vengadakrishnan@broadcom.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants