Ability to enable window2025 and noble stemcell download #703
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yharish991-brcm
commented
Sep 17, 2025
| ) | ||
|
|
||
| var metadataRegexp = regexp.MustCompile(`^(\.\/)?metadata/.*\.yml`) | ||
| var metadataRegexp = regexp.MustCompile(`^(.*\/)?metadata/.*\.yml`) |
There was a problem hiding this comment.
previously this is was only looking for file under metadata/ directory, but when the downloaded product is extracted it can be in a sub directory ex: download-product/product-name/metadata/, this change is to support that case.. the change will continue to support looking for file under metadata/, so this is non-breaking
yharish991-brcm
force-pushed
the
windows2025Stemcell
branch
from
1d3b2bc to
f7b512a
Compare
drich10
approved these changes
Sep 19, 2025
| ) | ||
|
|
||
| var metadataRegexp = regexp.MustCompile(`^(\.\/)?metadata/.*\.yml`) | ||
| var metadataRegexp = regexp.MustCompile(`^(.*\/)?metadata/.*\.yml`) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR