Adding flag to allow you to list out the opt-ins#318
Open
xtreme-steve-elliott wants to merge 1 commit intomainfrom
Open
Adding flag to allow you to list out the opt-ins#318xtreme-steve-elliott wants to merge 1 commit intomainfrom
xtreme-steve-elliott wants to merge 1 commit intomainfrom
Conversation
LemonmadeDesigns
approved these changes
Nov 7, 2023
LemonmadeDesigns
approved these changes
Nov 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on feedback from #300 this is PR simply adds the ability to list out available opt-ins using the
--listflag tosetup.sh. I had it check for the flag before the script runssudo -Kbecause listing out the options would not require admin and wouldn't actually be installing anything. If it is preferred that it runs after the analytics are turned on / off then I can rearrange some of the code to allow for that.In my view, the only potential
more-complicated-than-it-perhaps-needs-to-bepart is thehas_parammethod, which I have to allow for alternate flags (long and compact forms if desired in future), because I was tossing around the idea of allowing a compact flag like-las an alternative to--list.