Allow connections returned by go-stun to be used (for hole-punching, etc). #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per my earlier comment,
go-stunwas not properly relinquishing control over connections returned bystun.Discover()-- theAgentreadloop was still active, which was intercepting all messages sent to the socket.For me, this set of changes fixed the issue. It introduces a very simple
Stopmethod on theAgent, which pushes a struct to a channel that either of the Agent read loops mayselectto exit the read loop, effectively relinquishing the connection.Tests (such as they are) still pass. I'm not sure this is the best/most complete solution, but it made this library usable for me.