fix: propagate drop shadow blur resolution - #528
Open
avsavani wants to merge 1 commit into
Open
Conversation
bigtimebuddy
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
resolutionsupport toKawaseBlurFilterDropShadowFilter'sresolutionandpixelSizethrough to its internal Kawase blur passWhy
DropShadowFilteralready exposes aresolutionoption and defaults it to1, but the internalKawaseBlurFilterwas constructed without that value. On HiDPI/Retina renderers the blur pass can therefore do unnecessary DPR-scaled work, which is especially expensive for high-quality shadows.This keeps the fix small and centralized:
KawaseBlurFilternow owns its resolution option and pixel-size-aware padding, whileDropShadowFilterreuses the inner blur's actual padding instead of duplicating an approximate formula.Validation
npm run typesnpm run lintnpm run buildFixes #327