Fix release resources lifecycle on root destroy #639
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been struggling with being stuck at Pixi js <8.12 due to an application lifecycle issue. This only happens on >8.13. I think they stem from these changes in batching -- pixijs/pixijs#10885 & pixijs/pixijs#11581
The app renders correctly on first render, but when I navigate to a non Pixi view on the react app, and back to the pixi application, I'm greeted with a pixi crash:
I've added some comments in this issue pixijs/pixijs#11694, thinking this was an unsafe handling of the GPU Batches: I still feel that this kind of crash is not very graceful. But perhaps this is something we need to fix here also.
#625 reported that this happens only or React Strict, but it can also happen on navigation back and forth to the pixi application.
I've played around with the
releaseGlobalResourcesandremoveView, but only setting them both to true seems to work. It would be nice to prevet full destruction of the application between navigation events tho.