Refactor arm64 implementation and drop use of AVO #192
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Paulo Gomes <[email protected]>
Signed-off-by: Paulo Gomes <[email protected]>
The assembler arm64 implementation is closely aligned with the Go AVO version for amd64. However, given that there isn't support for amd64 in AVO, it feels easier to drop the AVO dependency and have a simpler assembly code for the time being. In the future, when AVO adds support for arm64 this may be reviewed. Signed-off-by: Paulo Gomes <[email protected]>
AVO is a great way to build assembly code and worked quite nicely for the amd64 implementation of the sha1cdblock. The lack of support for arm64 meant that little could be reused for arm64, which then decreases the benefit of having it in the first place. For UBC, the benefits of AVO are less clear as the Go code is largely a duplication of the assembler as it is just a very long number of statements. This decision will be reviewed once AVO supports arm64. Signed-off-by: Paulo Gomes <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AVO is a great way to build assembly code and worked quite nicely for the amd64 implementation of the sha1cdblock. The lack of support for arm64 meant that little could be reused for arm64, which then decreases the benefit of having it in the first place.
For UBC, the benefits of AVO are less clear as the Go code is largely a duplication of the assembler as it is just a very long number of statements.
This decision will be reviewed once AVO supports arm64.