Handle chunk loop in assembly while aligning both arm64 and amd64 implementations
#196
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Paulo Gomes <[email protected]>
The native implementation for the DV mask calculation were missing the noescape directives. For further optimisation, the wrapping funcs are now marked with nosplit. Signed-off-by: Paulo Gomes <[email protected]>
Signed-off-by: Paulo Gomes <[email protected]>
Signed-off-by: Paulo Gomes <[email protected]>
Signed-off-by: Paulo Gomes <[email protected]>
The recent changes seem to have caused a bug when -race is enabled, additional tests are under way to understand where the problem lies. Once the SIMD implementation is in place, this needs to be reverted. Signed-off-by: Paulo Gomes <[email protected]>
Owner
Author
|
Superseded by #198 due to the additional complexity this was introducing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes are a stepping stone for future SIMD optimisations. New comments have been added throughout the assembly code to make it easier to review and maintain the code in the future, with special attention to the stack layout.
The
blockimplementation for both architecture was handling the chunk loop in Go, as well as calling thecheckCollision. Both have now been moved to assembly.