Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address stray cppcheck warnings #73

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Address stray cppcheck warnings #73

wants to merge 1 commit into from

Conversation

gaul
Copy link
Contributor

@gaul gaul commented Aug 28, 2023

Reduce local scope where possible, handle realloc failure, and unify malloc error handling with realloc(NULL).

Reduce local scope where possible, handle realloc failure, and unify
malloc error handling with realloc(NULL).
@gaul
Copy link
Contributor Author

gaul commented Aug 28, 2023

This is basically noise but my C++ project accidentally ran its checks over pjdfstest so I thought I would clean this up.

Copy link
Collaborator

@ngie-eign ngie-eign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment is non-blocking given that the memory leak issue was preexisting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants