Prevent data race between SSL handshake and data read #4418
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is reported that a data race between SSL handshake and data read can cause handshake failure.
Note that although the issue is only reported on OpenSSL, the fix is done in the common SSL implementation. But this should be fine since the additional locking proposed in this patch is quite cheap (in other words, there's not much performance penalty since it only happens once at the start of the handshake).