You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Fixes integration tests for local development. I am not sure if these were running in CI but I am guessing if they were it was working because of some accidental setup not because they were correctly written. This fixes them locally for me and the PR will see if they run in CI and if so if these fixes also work in that environment.
I guess they were not running. As I am looking back on these, they were written way before I even moved this into the pkgjs org, so my guess is they were never working after that which is why the changes made since then were broken in the tests.
Anyway, because there is so much business logic in run.js which is intended to be run only with the actions environment, I believe we would need to use ACT to run a true integration tests for these. I am not a fan of that and would rather move logic into testable units. Sooo, while this is probably something we could merge, I am not sure of the value on it's own. I am not going to spend too much more time on this today, but will open a PR to fix the actual issue I was doing this to debug and we can decide if keeping these integration tests around is even worth it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes integration tests for local development. I am not sure if these were running in CI but I am guessing if they were it was working because of some accidental setup not because they were correctly written. This fixes them locally for me and the PR will see if they run in CI and if so if these fixes also work in that environment.