Skip to content

fix(test): fix integration tests#221

Merged
wesleytodd merged 1 commit into
mainfrom
fix-integration-tests
Aug 7, 2025
Merged

fix(test): fix integration tests#221
wesleytodd merged 1 commit into
mainfrom
fix-integration-tests

Conversation

@wesleytodd

Copy link
Copy Markdown
Member

Fixes integration tests for local development. I am not sure if these were running in CI but I am guessing if they were it was working because of some accidental setup not because they were correctly written. This fixes them locally for me and the PR will see if they run in CI and if so if these fixes also work in that environment.

@wesleytodd

wesleytodd commented Feb 24, 2025

Copy link
Copy Markdown
Member Author

I guess they were not running. As I am looking back on these, they were written way before I even moved this into the pkgjs org, so my guess is they were never working after that which is why the changes made since then were broken in the tests.

Anyway, because there is so much business logic in run.js which is intended to be run only with the actions environment, I believe we would need to use ACT to run a true integration tests for these. I am not a fan of that and would rather move logic into testable units. Sooo, while this is probably something we could merge, I am not sure of the value on it's own. I am not going to spend too much more time on this today, but will open a PR to fix the actual issue I was doing this to debug and we can decide if keeping these integration tests around is even worth it.

@wesleytodd
wesleytodd force-pushed the fix-integration-tests branch 3 times, most recently from 14142f5 to 21027aa Compare August 7, 2025 15:30
@wesleytodd wesleytodd changed the title fix(test): fix integration tests locally fix(test): fix integration tests Aug 7, 2025
@wesleytodd
wesleytodd force-pushed the fix-integration-tests branch 3 times, most recently from 1a495f5 to 0d42625 Compare August 7, 2025 15:50
@wesleytodd
wesleytodd force-pushed the fix-integration-tests branch from 0d42625 to 70cc5c0 Compare August 7, 2025 15:58
@wesleytodd
wesleytodd merged commit 6a0e663 into main Aug 7, 2025
9 checks passed
@wesleytodd
wesleytodd deleted the fix-integration-tests branch August 7, 2025 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant