Merge pull request #11384 from Hafsa-Naeem/i9202-stable_3_5_0-fix

#9202 Include 3.4 missing email templates in 3.5 upgrade

Author: Vitaliy-1

classes/migration/upgrade/v3_5_0/InstallEmailTemplates.php

@@ -28,11 +28,23 @@ protected function getEmailTemplateKeys(): array
     {
         return [
             'CHANGE_EMAIL',
+            'SUBMISSION_SAVED_FOR_LATER',
+            'SUBMISSION_NEEDS_EDITOR',
+            'REVIEW_COMPLETE',
+            'REVIEW_EDIT',
         ];
     }
 
     public function up(): void
     {
+        // remove the carried-over notifications template rows
+        DB::table('email_templates_default_data')
+            ->where('email_key', 'NOTIFICATION')
+            ->delete();
+        DB::table('email_templates')
+            ->where('email_key', 'NOTIFICATION')
+            ->delete();
+
         $xmlDao = new XMLDAO();
 
         $data = $xmlDao->parseStruct('registry/emailTemplates.xml', ['email']);