pkp/pkp-lib#11297 Update the code to retrieve discussions on the submission list the same way it's done at the submission page #11300
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
…ist the same way it's done at the submission page
jonasraoni
force-pushed
the
bugfix-stable-3_3_0-11297-fix-discussion-counter
branch
from
7296516 to
d6e88f6
Compare
taslangraham
approved these changes
Apr 24, 2025
bozana
approved these changes
Apr 29, 2025
There was a problem hiding this comment.
Hi @jonasraoni,
This looks good to me. I left just a few very minor questions, if you would like to address them :-)
| $handler->getAuthorizedContextObject(ASSOC_TYPE_USER_ROLES) | ||
| ); | ||
|
|
||
| $accessHelper = new QueriesAccessHelper($handler->getAuthorizedContext(), $request->getUser()); |
There was a problem hiding this comment.
You can use $user instead of $request->getUser() here
| @@ -413,13 +414,25 @@ public function getPropertyStages($submission, $stageIds = null) { | |||
| // Discussions in this stage | |||
| $stage['queries'] = array(); | |||
| $request = Application::get()->getRequest(); | |||
| $user = $request->getUser(); | |||
| import('lib.pkp.controllers.grid.queries.QueriesAccessHelper'); | |||
There was a problem hiding this comment.
Maybe to move this line closer to the line with new QueriesAccessHelper() ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.