Skip to content

Update plugins.xml #343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update plugins.xml #343

wants to merge 1 commit into from

Conversation

trp89
Copy link

@trp89 trp89 commented Dec 19, 2024

No description provided.

Copy link

@jonasraoni jonasraoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@asmecher I just saw some template variables can be escaped, but not sure if that's a big deal, given the current version already has this code.

@trp89 Not sure if this is compatible with the 3.5 release, if yes, you might update the PR and include ~3.5.0.0.

@asmecher
Copy link
Member

asmecher commented Apr 8, 2025

@trp89 and @jonasraoni, yes, that variable should be escaped before it is sent through the nl2br modifier. @trp89, could you review template escaping a little more broadly if you have the time?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants