Skip to content

Fixed unintended line break in issue_toc.tpl line 113.#405

Merged
asmecher merged 2 commits into
pkp:mainfrom
UMNLibraries:main
Aug 19, 2025
Merged

Fixed unintended line break in issue_toc.tpl line 113.#405
asmecher merged 2 commits into
pkp:mainfrom
UMNLibraries:main

Conversation

@johnbarneson

Copy link
Copy Markdown

No description provided.

@asmecher asmecher merged commit 342a2b0 into pkp:main Aug 19, 2025
1 check failed
@asmecher

Copy link
Copy Markdown
Member

Thanks, @johnbarneson!

@kaitlinnewson

Copy link
Copy Markdown
Member

Hi @johnbarneson and @asmecher, it looks like there is an issue with the folder naming in the release package (ojs-gopher-theme instead of gopher).

@asmecher

Copy link
Copy Markdown
Member

Whoops, good catch, @kaitlinnewson. I've reverted the commit. @johnbarneson, it's best to build the plugins using the plugin tool -- see https://docs.pkp.sfu.ca/dev/plugin-guide/en/release#build-and-package-your-plugin for details. It'll make sure the package directory is built as expected.

@johnbarneson

Copy link
Copy Markdown
Author

I always forget to rename the directory to match the 'product' name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants