-
Notifications
You must be signed in to change notification settings - Fork 48
Add Index Copernicus Export (importexport) v2.0.0.0 for OJS 3.5 #412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Thanks, @saddamalsalfi! @kaitlinnewson, are you available to review this? |
https://github.com/saddamalsalfi/ojs-quickstatements-export/releases/download/v1.0.0/quickstatements-v1.0.0-3.5.tar.gz MD5:52C7075AE890302A9D3D976D73A5E93C
|
Hi @saddamalsalfi, here are some of my initial review comments (I tried adding them to your repo but ran into some GitHub issues):
|
|
Hi @kaitlinnewson , Thank you for your valuable feedback. Based on your recommendations, we have implemented a series of significant updates to the Index Copernicus export plugin to improve its accuracy, reliability, and adherence to OJS standards. Summary of Changes: Reworked Fallback Affiliation: The hardcoded fallback affiliation to "Queen Arwa University" has been removed. By default, if an author has no affiliation, the field is now left blank to ensure correct metadata. However, the functionality to force a fallback has been retained as a configurable option, allowing developers at other institutions to enable it and specify their own default text if their system requires it. Standardized XML Generation: The use of CDATA has been replaced entirely with the standard createTextNode method. This ensures that special characters are handled correctly and automatically. Accurate Lead Author Identification: The logic for determining the "Lead Author" has been corrected. It now uses the primaryContactId from the publication's data instead of incorrectly assuming the first author is always the lead. Verified ORCID Export: An author's ORCID will now only be exported if it has been verified within the OJS system, which enhances the quality and reliability of the exported data. Improved Multilingual Handling: The logic for selecting author names in multilingual journals has been updated. It now prioritizes the publication's primary locale, ensuring the correct name (e.g., Arabic or English) is chosen to match the article's language. Consistent UI for Translations: All default="..." parameters have been removed from the templates (.tpl). This standardizes the handling of missing translations, causing them to be clearly displayed as ##key.name##, which aligns with OJS best practices. Completed Locale Files: The localization files (.po) have been updated with the missing common keys to ensure the user interface is fully translatable. The updated package is now available for your review. Download Link: https://github.com/saddamalsalfi/ojs-index-copernicus-export/releases/download/v2.0.0.0/copernicus_ojs3.5.0-1.tar.gz Thanks again for your help! |
|
Hi @saddamalsalfi, apologies for the delay. It looks like there is still an issue with the XML validation against the schema - based on the errors, it looks like the problem is in the xsd file itself, which I assume came from Index Copernicus. This means that your plugin may be producing invalid XML for their service, and the exports from the plugin may be rejected by Index Copernicus. I ran the xml produced in my installation through an online service and found a couple of issues, but there may be others:
You may need to manually review the schema against your code in order to ensure all required elements are set and in the right order. |
Package URL: https://github.com/saddamalsalfi/ojs-index-copernicus-export/releases/download/v2.0.0.0/copernicus_ojs3.5.0-1.tar.gz
MD5: f309e2680ae144cd9ffd98617a1efdf7
Compatibility: OJS 3.5.x
Summary: Adds "Index Copernicus Export" (importexport) plugin entry to plugins.xml. DOM-based builder with XSD validation, multi-language languageVersion blocks, DOAJ-like author affiliation resolution, DOI & CC license mapping.