Skip to content

Add release v3.4.0.0 of Dataverse plugin#470

Open
thiagolepidus wants to merge 5 commits into
pkp:mainfrom
lepidus:dataverse_3_4_0_0
Open

Add release v3.4.0.0 of Dataverse plugin#470
thiagolepidus wants to merge 5 commits into
pkp:mainfrom
lepidus:dataverse_3_4_0_0

Conversation

@thiagolepidus

Copy link
Copy Markdown

No description provided.

@asmecher

Copy link
Copy Markdown
Member

@thiagolepidus, sorry for the delay in reviewing these! Is it important to you to include the interim releases, or only the newest?

@thiagolepidus

Copy link
Copy Markdown
Author

Yes @asmecher, It might just be the newest.

@asmecher

Copy link
Copy Markdown
Member

Thanks, @thiagolepidus! Could you update the PR to include only the newest for each branch? Then I'll review and merge.

@thiagolepidus

Copy link
Copy Markdown
Author

Thanks, @thiagolepidus! Could you update the PR to include only the newest for each branch? Then I'll review and merge.

@asmecher done!

@asmecher

Copy link
Copy Markdown
Member

Hi @thiagolepidus! A few things to check...

  • The DataverseDAO::getSubmissionIByDOI function (and callers) doesn't check to see whether the DOI is in the current journal. You might end up working with a submission ID from another journal in a multijournal installation.
  • I see you're constructing request URLs for API interactions by manually building a string. Not a show-stopper, but it would be better to either construct them using a mechanism that provides escaping, or if not, at least to urlencode the parameters you're passing in.

These apply to both 3.3 and 3.4 packages.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants