Skip to content

feat: add OTLP gRPC exporter#815

Open
seuros wants to merge 3 commits intoplabayo:mainfrom
seuros:otel-grpc-clean
Open

feat: add OTLP gRPC exporter#815
seuros wants to merge 3 commits intoplabayo:mainfrom
seuros:otel-grpc-clean

Conversation

@seuros
Copy link
Contributor

@seuros seuros commented Feb 3, 2026

Added Opentelemetry to the gRPC exporter , this mirror the HTTP example.

Copy link
Member

@GlenDC GlenDC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some initial feedback. Once this is handled we can start looking into details. Even though I must say beyond this feedback it does look good. So don't think there will be much left to do (if anything at all) after we resolved these matters.

[dependencies]
base64 = { workspace = true }
flate2 = { workspace = true, optional = true }
opentelemetry = { workspace = true, optional = true }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there should be no need for you to import opentelemetry or opentelemetry-sdk directly. Both are afaik already part of rama-core and can be used via there.

opentelemetry-proto should be dropped (see other comment).

println!("cargo::rerun-if-changed=proto");
}

#[cfg(feature = "opentelemetry")]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this can be replaced with compiling grpc protos

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should be no need to watch these env variables btw we already watch proto folder, should be enough for this, this is just about building the code from proto so no need to check env variables

The opentelemetry feature used raw prost_build::Config which requires
system protoc, unlike the protobuf feature which goes through
rama-grpc-build's vendored protoc.
@GlenDC
Copy link
Member

GlenDC commented Feb 16, 2026

Let me know @seuros if you need any guidance or help with this one.
Will be good to have it as it will mean we can remove tonic and tonic-prost from the dep tree:

% cargo tree --all-features -i tonic
tonic v0.14.4
├── opentelemetry-proto v0.31.0
│   └── opentelemetry-otlp v0.31.0
│       └── rama v0.3.0-rc1 (/Users/glendc/code/github.com/plabayo/rama)
└── tonic-prost v0.14.4
    └── opentelemetry-proto v0.31.0 (*)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants