Open
Conversation
M-Kusumgar
commented
Feb 18, 2026
GlenDC
requested changes
Feb 22, 2026
Member
GlenDC
left a comment
GlenDC
left a comment
There was a problem hiding this comment.
Please address the comments. Also sync with main please.
Member
|
@soundofspace can you give this one a look, once you are happy I'll do the final review, but will be good if you can give it a check as well as you might not have seen it since your out of date review on the previous PR in this series. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This one taught me a lot so thank you. Turns out I didn't fully understand how TLS works or what the difference between a transparent HTTP proxy and a MITM one is. I also had no idea what Socks5 was before this.
Also I got stuck for a bit with
async move ||vsmove || {async move {...}}but happy with it now.There are a lot of benchmarks with this addition. I reduced the sample count to 50 because it was taking a long time to run, happy for it to be raised if you want it back up to 200 but I thought this was more reasonable.
PS: you may not have to do it but I had to actually increase my
ulimitto get all these scenarios to run, just in case you run into the "too many open files" error.