Skip to content

Thread arguments through Compose tree instead of storing in Container#81

Merged
VictorB00 merged 1 commit into
mainfrom
thread-arguments-through-compose-tree
Jun 8, 2026
Merged

Thread arguments through Compose tree instead of storing in Container#81
VictorB00 merged 1 commit into
mainfrom
thread-arguments-through-compose-tree

Conversation

@VictorB00

Copy link
Copy Markdown
Collaborator

Summary

  • Moves arguments out of the Container object and threads it through the Compose tree as a parameter, following unidirectional data flow
  • Renames initWith(arguments) to makeContainer() — containers are now argument-agnostic
  • Makes formRepository non-nullable in ContainerImpl, eliminating null-safe calls
  • Wraps trigger modal stacks in key(stack.id) for correct Compose recomposition identity
  • Changes remember keys from arguments to stable identifiers (id, componentId, data) so containers aren't recreated on argument changes

Test plan

  • Verify embeddings render correctly with arguments passed through the Compose tree
  • Confirm form state is preserved when arguments change (container no longer recreated)
  • Test trigger modals open/close correctly with the new key(stack.id) wrapping
  • Verify template variables still resolve arguments in createVariableForTemplate

@VictorB00 VictorB00 merged commit d06bf9b into main Jun 8, 2026
1 check passed
@VictorB00 VictorB00 deleted the thread-arguments-through-compose-tree branch June 8, 2026 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant