Conversation
danixeee
commented
Sep 22, 2025
| export default defineConfig({ | ||
| build: { | ||
| target: 'node20', | ||
| target: "node18", |
Contributor
Author
There was a problem hiding this comment.
the only change, everything else is formatting ' -> "
danixeee
force-pushed
the
fix-build-target
branch
from
661e1ff to
bd4ac55
Compare
ivansenic
approved these changes
Sep 22, 2025
Contributor
ivansenic
left a comment
ivansenic
left a comment
There was a problem hiding this comment.
Fine, check only the tsconfig that was unnecessary removed imo..
Comment on lines
-15
to
-24
| "resolveJsonModule": true, | ||
| "declaration": true, | ||
| "declarationMap": true, | ||
| "sourceMap": true, | ||
| "noUnusedLocals": true, | ||
| "noUnusedParameters": true, | ||
| "noImplicitReturns": true, | ||
| "noFallthroughCasesInSwitch": true, | ||
| "allowSyntheticDefaultImports": true, | ||
| "isolatedModules": true, |
Contributor
There was a problem hiding this comment.
what's with all these? why not keep them? noUnusedLocals, noUnusedParameters, noImplicitReturns, etc
Contributor
Author
There was a problem hiding this comment.
i can revert that yup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.