Inject plainly sdk instead of using a global instance#15
Merged
Conversation
ivansenic
requested changes
Sep 26, 2025
Contributor
ivansenic
left a comment
ivansenic
left a comment
There was a problem hiding this comment.
Very good, not sure about this one thing?
|
|
||
| const server = new PlainlyMcpServer(); | ||
| const apiClient = createApiClient({ | ||
| baseUrl: env.PLAINLY_API_URL, |
Contributor
There was a problem hiding this comment.
wait is there default for this? this should not be given
Contributor
Author
There was a problem hiding this comment.
yes, in env.ts:
Lines 8 to 11 in 067dd00
e.g. in Smithery you can set env variables for your server, but api key is set through user configuration. So I think it's fine for defaults to be in env.ts
ivansenic
approved these changes
Sep 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.