Conversation
vladavoX
commented
Dec 9, 2025
| client: AxiosInstance | ||
| ) { | ||
| return (...args: Parameters<T>) => fn(client, ...args); | ||
| function withClient<A extends unknown[], R>(fn: (client: AxiosInstance, ...args: A) => R, client: AxiosInstance) { |
| parametrization: { value: string; mandatory: boolean }; | ||
| } => { | ||
| return layer.parametrization != null && layer.parametrization.expression; | ||
| return !!layer.parametrization?.expression; |
Contributor
Author
There was a problem hiding this comment.
here, bunch of any -> unknown. unknown is always better, because it doesn't allow you to use something random, for example:
some.random <--- this will give error if some: unknown
some.random <--- this will be ignored if some: any
| state: render.state, | ||
| }); | ||
| } catch (err: any) { | ||
| } catch (err: unknown) { |
Contributor
Author
There was a problem hiding this comment.
this is changed, and below
| templateVariantName: render.templateName, | ||
| }); | ||
| } catch (err: any) { | ||
| } catch (err: unknown) { |
Contributor
Author
There was a problem hiding this comment.
this is changed, and below on line 137
| } | ||
| }; | ||
|
|
||
| export const normalizeError = (err: unknown): { message: string; details?: unknown } => { |
Contributor
Author
There was a problem hiding this comment.
added, used in renderItem line 137
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.