Conversation
danixeee
force-pushed
the
render-tool
branch
from
79144dd to
c91ceb2
Compare
danixeee
force-pushed
the
render-tool
branch
from
c91ceb2 to
32c1fcf
Compare
ivansenic
left a comment
ivansenic
left a comment
There was a problem hiding this comment.
Imo we need immediatelly getRender or something like this, and we need to solve pooling, so I can visually have the final video(s).. Imo that should be done in this task..
Some things need fixing imo, especially in the model
| type: "text", | ||
| text: `Failed to create render: ${err}`, |
There was a problem hiding this comment.
not really good? would add error in structured content.. Seems also that validation passed, but call failed? here he is using wrong parameter name 9.99 -> you did not exclude static params from the template
There was a problem hiding this comment.
plus he does not understand it's not good
There was a problem hiding this comment.
I have created a custom error with solutions for each. I have no idea if this works or not with LLM, lets test it a bit. The idea is to give LLM instructions what to do in case of any known error happens. Wdyt?
ivansenic
left a comment
ivansenic
left a comment
There was a problem hiding this comment.
Not bad, have a look on comments..
| outputSchema: Output, | ||
| }, | ||
| async ({ isDesign, projectDesignId, templateVariantId, parameters }) => { | ||
| // TODO: Handle object parameters "my.parameter.x" |
There was a problem hiding this comment.
i guess not needed, if explained how "keyed" params should be represented in the parameters object (just add instruction point)..
|
|
||
| // Successful submission | ||
| return { | ||
| content: [ |
There was a problem hiding this comment.
does it make sence that we send also a https://modelcontextprotocol.io/specification/2025-06-18/server/tools#resource-links for this render html page, so link to app.plainlyvideos.com/renderid imo this makes a lot of sense, since I could at least get link until we have pooling
content is array and you can send multiple things
There was a problem hiding this comment.
I tried but it is not really working like that, see above. But I can include a link in the output
2 participants
No description provided.