fix: prepareEditorCommand doesn't accept arguments #311
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The prepareEditorCommand function now properly handles editor commands with arguments (e.g., "zed --wait") by splitting the editor string and passing both the executable and its arguments to exec.Command. This fixes issue plandex-ai#98 where editors with arguments specified via EDITOR or VISUAL environment variables were not being recognized correctly. Signed-off-by: majiayu000 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes #98
Changes
prepareEditorCommandfunction inapp/cli/cmd/tell.goto properly parse editor commands with argumentsstrings.Fieldsto split the editor string into the executable name and its arguments--waitinzed --wait) are now properly passed to the editor commandTechnical Details
The fix splits the editor command using
strings.Fields(editor)and extracts:editorName: the first part (executable)editorArgs: remaining parts (arguments)These arguments are then prepended to the editor-specific arguments before the filename, ensuring proper command construction.
Generated with Claude Code