fix: improve Response Failed UX for pre-response and mid-response errors#890
Merged
Conversation
originchoi
commented
Mar 6, 2026
originchoi
commented
- Show dedicated "Response Failed" UI when error occurs before any response
- Hide Copy button when no response content exists
- Show Retry button for all failed responses regardless of content
- Add 60s timeout for submitted state to handle unresponsive servers
- Create placeholder assistant message for errors in submitted state
- Show dedicated "Response Failed" UI when error occurs before any response - Hide Copy button when no response content exists - Show Retry button for all failed responses regardless of content - Add 60s timeout for submitted state to handle unresponsive servers - Create placeholder assistant message for errors in submitted state
Deploying agent8-sandbox with
|
| Latest commit: |
a0e0875
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://23836953.agent8-sandbox.pages.dev |
| Branch Preview URL: | https://feature-agent8-polish-phase2.agent8-sandbox.pages.dev |
Deploying agent8-dev with
|
| Latest commit: |
a0e0875
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://3f4fe0b5.agent8-dev.pages.dev |
| Branch Preview URL: | https://feature-agent8-polish-phase2.agent8-dev.pages.dev |
Deploying agent8-staging-sandbox with
|
| Latest commit: |
a0e0875
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://ae68892e.agent8-stg-sandbox.pages.dev |
| Branch Preview URL: | https://feature-agent8-polish-phase2.agent8-stg-sandbox.pages.dev |
Deploying agent8-production with
|
| Latest commit: |
4049731
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://3494a2f0.agent8-prod.pages.dev |
| Branch Preview URL: | https://feature-agent8-polish-phase2.agent8-prod.pages.dev |
Deploying agent8-staging with
|
| Latest commit: |
4049731
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://ccf3e79d.agent8-stg.pages.dev |
| Branch Preview URL: | https://feature-agent8-polish-phase2.agent8-stg.pages.dev |
Deploying agent8-pr with
|
| Latest commit: |
4049731
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://e2a00cde.agent8-pr.pages.dev |
| Branch Preview URL: | https://feature-agent8-polish-phase2.agent8-pr.pages.dev |
Deploying agent8-production-old with
|
| Latest commit: |
a0e0875
|
| Status: | ⚡️ Build in progress... |
dinoksb
reviewed
Mar 6, 2026
| } | ||
|
|
||
| const timer = setTimeout(() => { | ||
| stop(); |
There was a problem hiding this comment.
stop() 대신 stopRef.current() 를 사용하는 것이 좋을 것 같습니다.
- 코드베이스 패턴 유지
- 스테일 클로저 회피
dinoksb
reviewed
Mar 6, 2026
|
|
||
| const timer = setTimeout(() => { | ||
| stop(); | ||
|
|
There was a problem hiding this comment.
setFakeLoading(false) 와 같은 UI 정리는 필요없을지 확인 부탁드립니다.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.