fixes type hinting issues w/ click==8.4#1219
Open
ischneider wants to merge 1 commit into
Open
Conversation
ischneider
force-pushed
the
fix-click-type-hints
branch
from
7ec5451 to
7f3f413
Compare
asonnenschein
approved these changes
Jun 10, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses mypy type-check failures introduced by Click 8.4.0 by updating custom CLI ParamType implementations, and removes the Click <8.4.0 dependency cap now that the typing issue is being resolved.
Changes:
- Loosen the Click dependency constraint to allow Click 8.4+.
- Update
CommaSeparatedString/CommaSeparatedFloatparameter types to avoid overridingStringParamType.convert()with incompatible return types.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
pyproject.toml |
Removes the Click <8.4.0 cap so newer Click versions can be installed. |
planet/cli/types.py |
Refactors comma-separated param types to align with Click 8.4 typing expectations. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+24
to
28
| class CommaSeparatedString(click.types.ParamType[list[str]]): | ||
| """A list of strings that is extracted from a comma-separated string.""" | ||
| name = 'VALUE' | ||
|
|
||
| def convert(self, value, param, ctx) -> List[str]: |
|
|
||
|
|
||
| class CommaSeparatedFloat(click.types.StringParamType): | ||
| class CommaSeparatedFloat(click.types.ParamType[list[float]]): |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue(s):
Closes #1218
Proposed Changes:
Not intended for changelog:
PR Checklist: