Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support null in Airbyte schema column type #123

Merged
merged 5 commits into from
Feb 20, 2025
Merged

Support null in Airbyte schema column type #123

merged 5 commits into from
Feb 20, 2025

Conversation

notfelineit
Copy link
Contributor

@notfelineit notfelineit commented Feb 20, 2025 •
edited
Loading

This PR modifies the returned property type to support nullable columns:

"type": ["string", "null"]

According to https://docs.airbyte.com/understanding-airbyte/supported-data-types/#unions this would be the syntax.

@notfelineit
Copy link
Contributor Author

Local testing

null is discovered as a column type:
CleanShot 2025-02-20 at 13 43 47@2x

null values are being passed:
CleanShot 2025-02-20 at 13 42 54@2x

@notfelineit notfelineit marked this pull request as ready for review February 20, 2025 21:44
@notfelineit notfelineit merged commit d800f4c into main Feb 20, 2025
3 checks passed
@notfelineit notfelineit deleted the add-null-to-schema branch February 20, 2025 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvanw nickvanw nickvanw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@notfelineit @nickvanw