fix: handle mmap EACCES/EBADF errors in afterForkChild #124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a child process tries to remap the arena after fork, mmap with MAP_FIXED may fail with EACCES or EBADF on certain kernel versions when replacing a MAP_SHARED mapping that's also mapped in the parent. This fix: - Adds fsync() to ensure copied data is persisted before remapping - Falls back to munmap + mmap when the direct mmap fails with EACCES or EBADF Fixes: #123 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
cargo buildand other programs that fork heavilyfsync()to ensure copied data is persisted before remappingmunmap+mmapwhen direct mmap fails with EACCES or EBADFTest plan
Fixes #123
🤖 Generated with Claude Code