-
Notifications
You must be signed in to change notification settings - Fork 15
Updated Anthropic Claude model. #13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates support for new Anthropic Claude model variants by adding rate limit entries, adjusting default model selection, and updating token handling.
- Reformats and extends
MODEL_RATE_LIMITSwith new Anthropic Claude models. - Modifies token rate limiting and counting logic to recognize Anthropic providers.
- Changes the default model under AWS to the new Claude-3-5-sonnet-v2 variant.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/coverup/llm.py | Reformatted rate limits dict, added Anthropic model entries, updated token limit/count logic. |
| src/coverup/coverup.py | Updated default_model() to return the new anthropic.claude-3-5-sonnet-20241022-v2:0 for AWS. |
Comments suppressed due to low confidence (1)
src/coverup/llm.py:82
- The
count_tokensfunction lacks a docstring; add one to explain its purpose, parameters, and return value, especially describing how different providers are handled.
def count_tokens(model_name: str, completion: dict):
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
- removed obsolete assertion;
jaltmayerpizzorno
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be better not to hardcode that string...
No description provided.