Design tab columns #140
Open
Design tab columns #140
+116
−286
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
|
@angiehemans is attempting to deploy a commit to the Plasmic Team on Vercel. A member of the Team first needs to authorize it. |
jaslong
reviewed
May 2, 2025
| will cause it to stretch to fill the parent container. | ||
| </div> | ||
| } | ||
| <> |
| @@ -78,7 +67,7 @@ class SizeSection_ extends StyleComponent< | |||
| constructor(props: StyleComponentProps) { | |||
| super(props); | |||
| this.state = { | |||
| showMore: false, | |||
| isOpen: true, | |||
There was a problem hiding this comment.
Why is this added as a state? I don't think it ever changes.
Also, since it is now a stateless component, can you change it to a functional component?
| @@ -654,7 +484,7 @@ const FlexGrowControls = observer(function FlexGrowControls(props: { | |||
|
|
|||
| function toDisplay(val: string, stretchLabel: string, isRoot: boolean) { | |||
| if (val === "wrap") { | |||
| val = "Hug content"; | |||
There was a problem hiding this comment.
I think there might be more instances of "Hug content" scattered around the codebase. Maybe you could store this string in a variable in Labels.ts? Same with the other labels.
| @@ -1028,7 +1028,7 @@ export const FullRow = React.forwardRef(function FullRow( | |||
| ? { | |||
| display: "grid", | |||
| gridTemplateColumns: "1fr ".repeat(props.children.length), | |||
| gridColumnGap: 24, | |||
| gridColumnGap: 28, | |||
There was a problem hiding this comment.
Bit concerned at changing the gap for all FullRow instances... why was this needed?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the design of the "Size" section of the design tab to be more compact and use a two column layout.
