fix(patch): include writeOnly fields and remove deprecated schema fields #184
+141
−74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WriteOnly fields (like passwords) are never returned by cloud provider Read operations, but Formae stores them in its own state. Previously, when both existing and desired state had the same writeOnly value, no patch operation was generated. This caused updates to fail when the cloud provider required these fields. Fix by stripping writeOnly fields from the existing state before patch comparison, causing jsonpatch to generate an "add" operation for these fields in every update.
JeroenSoeters
force-pushed
the
fix/writeonly-patch-generation
branch
from
90f56c9 to
d07b5ae
Compare
These fields were never used and are being sunset from the plugin schema.
discount-elf
approved these changes
Jan 27, 2026
browdues
approved these changes
Jan 27, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
nonprovisionableandpersistfields from the schema - these were never used and are being sunset