feat: migrate from golang-commons lifecycle to subroutines#158
Draft
feat: migrate from golang-commons lifecycle to subroutines#158
Conversation
Replace the golang-commons controller/lifecycle framework with the new
standalone github.com/platform-mesh/subroutines package which provides
a cleaner, composable API.
Key changes:
- Split Subroutine interface into Processor, Finalizer (compose as needed)
- runtimeobject.RuntimeObject → client.Object (standard controller-runtime)
- errors.OperatorError → plain error
- ctrl.Result → subroutines.Result (OK, OKWithRequeue, Pending, Stop)
- Replace lifecycle builder with lifecycle.New() + manual controller setup
- Replace golang-commons logger with logr via log.FromContext(ctx)
- Replace ratelimiter wrapper with workqueue.NewTypedItemExponentialFailureRateLimiter
- Condition type names: {Name}_Ready → {Name}
- Remove k8s.io replace directives (no longer needed)
Signed-off-by: Bastian Echterhölter <bastian.echterhoelter@sap.com>
On-behalf-of: @SAP <bastian.echterhoelter@sap.com>
The new subroutines lifecycle uses log.FromContext(ctx) and doesn't need explicit logger or CommonServiceConfig parameters. Signed-off-by: Bastian Echterhölter <bastian.echterhoelter@sap.com> On-behalf-of: @SAP <bastian.echterhoelter@sap.com>
The subroutines lifecycle now accepts mcreconcile.Request natively, so remove the manual mccontext.WithCluster / ctrl.Request wrapping and drop unused imports. Signed-off-by: Bastian Echterhölter <bastian.echterhoelter@sap.com> On-behalf-of: @SAP <bastian.echterhoelter@sap.com>
Signed-off-by: Bastian Echterhölter <bastian.echterhoelter@sap.com> On-behalf-of: @SAP <bastian.echterhoelter@sap.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
golang-commons/controller/lifecyclewith standalonegithub.com/platform-mesh/subroutinespackageSubroutineinterface into composableProcessor,Finalizerinterfaces — subroutines only implement what they needBreaking Change
Status condition type names changed from
{SubroutineName}_Ready→{SubroutineName}(e.g.WorkspaceSubroutine_Ready→WorkspaceSubroutine). The aggregateReadycondition is unchanged.What stays
golang-commonsremains forlogger,config,context,traces— only the lifecycle/controller orchestration packages are replaced.