Skip to content

Prepare for zoneless development #138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gkrajniak merged 4 commits into from
Nov 18, 2025
Merged

Prepare for zoneless development #138

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cd5bce2
Prepare for zoneless development
gkrajniaksap Nov 17, 2025
84cf9a4
Merge branch 'main' into feat/provide-zoneless-apollo
gkrajniak Nov 17, 2025
a47eb05
fix tests
gkrajniaksap Nov 18, 2025
77e23f2
Merge branch 'main' into feat/provide-zoneless-apollo
gkrajniak Nov 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion projects/lib/jest.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ module.exports = {
branches: 90,
functions: 95,
lines: 95,
statements: -4,
statements: -5,
},
},
moduleNameMapper: {
Expand Down
2 changes: 1 addition & 1 deletion projects/lib/portal-options/services/crd-gateway-kcp-patch-resolver.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ export class CrdGatewayKcpPatchResolver {
entityId?: string,
kind?: string,
) {
if (nextNode.context.kcpPath) {
if (nextNode.context?.kcpPath) {
this.gatewayService.updateCrdGatewayUrlWithEntityPath(
nextNode.context.kcpPath,
);
Expand Down
10 changes: 7 additions & 3 deletions projects/lib/services/resource/apollo-factory.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { GatewayService } from './gateway.service';
import { ResourceNodeContext } from './resource-node-context';
import { Injectable, NgZone, inject } from '@angular/core';
import { Injectable, inject } from '@angular/core';
import {
type ApolloClientOptions,
ApolloLink,
Expand Down Expand Up @@ -39,20 +39,24 @@ class SSELink extends ApolloLink {
}
}

const noopZone = {
run: (fn: any) => fn(),
runOutsideAngular: (fn: any) => fn(),
} as any;

@Injectable({
providedIn: 'root',
})
export class ApolloFactory {
private httpLink = inject(HttpLink);
private ngZone = inject(NgZone);
private gatewayService = inject(GatewayService);

public readonly apollo = (
nodeContext: ResourceNodeContext,
readFromParentKcpPath = false,
): Apollo =>
new Apollo(
this.ngZone,
noopZone,
this.createApolloOptions(nodeContext, readFromParentKcpPath),
);

Expand Down
Loading