-
Notifications
You must be signed in to change notification settings - Fork 0
feat: edit entity btn #24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
# Conflicts: # projects/wc/src/app/initializers/luigi-wc-initializer.spec.ts
# Conflicts: # projects/wc/src/app/components/generic-ui/list-view/list-view.component.spec.ts # projects/wc/src/app/components/generic-ui/list-view/list-view.component.ts
|
@makdeniss Your ticket is in the wrong project board, please assign it to the correct one,. |
did so. Hopefully it is now correct. Sorry about that. |
...app/components/generic-ui/list-view/create-resource-modal/create-resource-modal.component.ts
Outdated
Show resolved
Hide resolved
...app/components/generic-ui/list-view/create-resource-modal/create-resource-modal.component.ts
Outdated
Show resolved
Hide resolved
...app/components/generic-ui/list-view/create-resource-modal/create-resource-modal.component.ts
Outdated
Show resolved
Hide resolved
...app/components/generic-ui/list-view/create-resource-modal/create-resource-modal.component.ts
Outdated
Show resolved
Hide resolved
...app/components/generic-ui/list-view/create-resource-modal/create-resource-modal.component.ts
Outdated
Show resolved
Hide resolved
...app/components/generic-ui/list-view/create-resource-modal/create-resource-modal.component.ts
Outdated
Show resolved
Hide resolved
WalkthroughAdds ResourceService.update (inserted twice) that strips __typename and performs no-cache GraphQL mutations; introduces stripTypename util and tests; extends CreateResourceModal and ListView to support edit flow (prefill, disable create-only fields, emit update) and updates related tests/styles. Changes
Estimated code review effort🎯 4 (Complex) | ⏱️ ~60 minutes 📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Free 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Tip 👮 Agentic pre-merge checks are now available in preview!Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
Please see the documentation for more information. Example: reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"
mode: "warning"
instructions: |
Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).Please share your feedback with us on this Discord post. Note 🎁 Summarized by CodeRabbit FreeYour organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://app.coderabbit.ai/login. Comment |
# Conflicts: # projects/lib/services/resource/resource.service.ts
...app/components/generic-ui/list-view/create-resource-modal/create-resource-modal.component.ts
Outdated
Show resolved
Hide resolved
projects/wc/src/app/components/generic-ui/list-view/list-view.component.ts
Outdated
Show resolved
Hide resolved
projects/wc/src/app/components/generic-ui/list-view/list-view.component.html
Show resolved
Hide resolved
...app/components/generic-ui/list-view/create-resource-modal/create-resource-modal.component.ts
Outdated
Show resolved
Hide resolved
...app/components/generic-ui/list-view/create-resource-modal/create-resource-modal.component.ts
Outdated
Show resolved
Hide resolved
|
@gkrajniak I have resolved all the comments / issues. The only problem is that I cannot find a solution to only initialise the form once either with or without values (using signals perhaps?). Maybe you have some hints for that? |
# Conflicts: # projects/wc/src/app/components/generic-ui/list-view/list-view.component.ts
you use the |
I am not sure I understood you or maybe you misunderstood me. The problem is that I am doing this in and also this in I would like to do it only once. I didn't find a way to do it yet. |
ok if it needs to stay it needs tio stay or we recreate the form or have an additional logic to set values on the form |
Summary by CodeRabbit
New Features
UI/Style
Reliability
Tests