Skip to content

Conversation

@Sobyt483
Copy link
Collaborator

@Sobyt483 Sobyt483 commented Sep 18, 2025

openmfp/portal-ui-lib#333

Summary by CodeRabbit

  • New Features

    • Detail and List views support grouped fields/columns with labels, optional delimiters, and per-group multiline display.
    • Inline delete action added to list rows; create modal bindings updated.
    • Default fields/columns shown when UI config omits them.
  • Style

    • Added multiline styling for grouped values.
  • Refactor

    • Views migrated to a reactive/computed model for UI state.
  • Tests

    • Broadened unit tests for field processing, view defaults, error handling, and list/detail behaviors.
  • Chores

    • Updated build/config and added a public models entry point.

@Sobyt483 Sobyt483 requested a review from gkrajniak September 18, 2025 10:45
@Sobyt483 Sobyt483 self-assigned this Sep 18, 2025
@Sobyt483 Sobyt483 added the enhancement New feature or request label Sep 18, 2025
@coderabbitai
Copy link

coderabbitai bot commented Sep 18, 2025

Walkthrough

Updates introduce grouped field support (delimiter → delimiter, new multiline), add a processFields utility and tests, migrate several UI components to Angular signals with grouped/multiline rendering, adjust model packaging and TypeScript path aliases, and update imports and related tests.

Changes

Cohort / File(s) Summary of changes
Model type update
projects/lib/models/models/resource.ts
Renamed group.deliminatorgroup.delimiter; added group.multiline?: boolean.
Models packaging & public entry
projects/lib/models/ng-package.json, projects/lib/models/public-api.ts, tsconfig.json
Added ng-packagr config and public-api.ts re-export; added TS path alias @platform-mesh/portal-ui-lib/models./projects/lib/models/public-api.ts.
Workspace TypeScript config
projects/wc/tsconfig.json
Set rootDir: "../.." and added "../lib/**/*" to include.
Services public API & imports
projects/lib/services/public-api.ts, projects/lib/services/resource/resource.service.ts
Removed export ./models from services public API; updated imports in resource service to @platform-mesh/portal-ui-lib/models.
Resource field utility
projects/lib/utils/utils/resource-field-by-path.ts
Changed getResourceValueByJsonPath signature to accept `field: { jsonPathExpression?: string; property?: string
Detail view: logic, template, styles, tests
projects/wc/src/app/components/generic-ui/detail-view/detail-view.component.ts, .../detail-view.component.html, .../detail-view.component.scss, .../detail-view.component.spec.ts
Migrated to signals/computed; resourceDefinition, workspacePath, resourceFields → computed accessors; added viewFields from processFields; template switched to function-call accessors and supports grouped fields with group.multiline and group.delimiter; added .multiline CSS; expanded and refactored tests.
List view: logic, template, styles, tests
projects/wc/src/app/components/generic-ui/list-view/list-view.component.ts, .../list-view.component.html, .../list-view.component.scss, .../list-view.component.spec.ts
Migrated to signals/computed; heading, resourceDefinition, columns → computed; added viewColomns via processFields; template uses computed accessors, supports grouped/multiline columns and a delete action; added .multiline CSS; broadened tests.
Field processing utility & tests
projects/wc/src/app/utils/proccess-fields.ts, projects/wc/src/app/utils/proccess-fields.spec.ts
Added processFields with exported types ProcessedValue, ProcessedGroup, ProcessedFieldDefinition; implements grouping aggregation and preserves metadata; comprehensive unit tests added.
Organization management tests
projects/wc/src/app/components/organization-management/organization-management.component.spec.ts
Added tests for invalid organization name validation and portless navigation; minor import formatting.

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~60 minutes


📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Free

📥 Commits

Reviewing files that changed from the base of the PR and between 1d68c4b and 901cdd6.

📒 Files selected for processing (1)
  • docs/readme-generic-ui.md (3 hunks)
✅ Files skipped from review due to trivial changes (1)
  • docs/readme-generic-ui.md

Note

🎁 Summarized by CodeRabbit Free

Your organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://app.coderabbit.ai/login.

Comment @coderabbitai help to get the list of available commands and usage tips.

@gkrajniak
Copy link
Collaborator

Could you especially when we work on the ui changes add screenshots of the new feature, that would be very useful.

@Sobyt483
Copy link
Collaborator Author

Could you especially when we work on the ui changes add screenshots of the new feature, that would be very useful.

Sure

@Sobyt483 Sobyt483 merged commit 2e58806 into main Sep 19, 2025
7 checks passed
@gkrajniak gkrajniak changed the title Feat/combine fields feat: combine fields Sep 19, 2025
@Sobyt483
Copy link
Collaborator Author

image image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants