[KAAP-550] Added force remove flag in byohctl deauthorise and decommission - #201
Merged
Conversation
…-node . Added force removal of byohost CR in case of DU deletion
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
sebastian-pf9
requested changes
Aug 19, 2026
sebastian-pf9
left a comment
Collaborator
There was a problem hiding this comment.
needs test. (code lgtm)
snslk
force-pushed
the
private/snh/KAAP-550
branch
from
August 19, 2026 09:49
75cabbe to
dce0e9f
Compare
sebastian-pf9
approved these changes
Aug 19, 2026
sebastian-pf9
left a comment
Collaborator
There was a problem hiding this comment.
no changes to previous commit. still lgtm
indradhanush
requested changes
Aug 19, 2026
indradhanush
left a comment
Collaborator
There was a problem hiding this comment.
Request changes because context.TODO and package level client.
Additional suggestions: Please look into adding an E2E test for the --force flag. We already have existing test Ginkgo based suites in this repo, which should help.
snslk
force-pushed
the
private/snh/KAAP-550
branch
from
August 20, 2026 09:43
78a17ea to
830f403
Compare
indradhanush
left a comment
Collaborator
There was a problem hiding this comment.
Sorry for not approving yet. I think I was not super clear in my previous comment.
snslk
force-pushed
the
private/snh/KAAP-550
branch
from
August 24, 2026 06:31
ba5757c to
7d5ce21
Compare
snslk
force-pushed
the
private/snh/KAAP-550
branch
from
August 25, 2026 08:45
7d5ce21 to
5fa431c
Compare
…nterface , refactored test code accordingly
snslk
force-pushed
the
private/snh/KAAP-550
branch
from
August 25, 2026 10:06
08a5c04 to
d52b23e
Compare
indradhanush
approved these changes
Aug 27, 2026
indradhanush
left a comment
Collaborator
There was a problem hiding this comment.
Approved to unblock. Please fix merge conflicts to proceed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add force flag for byohctl deauthorise and byohctl decommission .
BUG
https://platform9.atlassian.net/browse/KAAP-550
Testing
After onboarding byohost deleted DU , not able to deauthorise or decommission . Using updated deauthorise binary successfully able to deauthorise and decommission host .