build(deps): upgrade kube-vip from v0.5.5 to v0.9.2 - #217
Open
sebastian-pf9 wants to merge 3 commits into
Open
Conversation
indradhanush
approved these changes
Aug 20, 2026
sebastian-pf9
force-pushed
the
claude/upgrade-kube-vip-e27734
branch
from
August 20, 2026 15:54
4a5ffbe to
6890892
Compare
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Drop the insomniacslk/dhcp replace directive (added for kube-vip 0.5.1) and upgrade kube-vip to v0.9.2, a stable release with modern dependencies. Update deleteIP() to handle the new vip.NewConfig API (returns []Network, requires additional parameters) and DeleteIP's new error signature. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
Collaborator
Author
|
I can reproduce the e2e failure here. this is more complicated than expected. |
Collaborator
Maybe not worth it at the moment? |
kube-vip v0.9.2 requires vip_subnet to be set explicitly: its SelectSubnet() only overrides the default when the env var is non-empty, and nothing else fills in the "32 for IPv4" default the --vipSubnet flag help text describes. Left unset, kube-vip crash-loops on every control-plane host with: invalid CIDR "10.89.0.151/": could not format address with subnetMask '' which blocks the control-plane endpoint from ever coming up, so kubeadm init/join times out waiting for a healthy API server. Verified locally: all 3 previously-failing single-BYOH-host specs now pass. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
sebastian-pf9
force-pushed
the
claude/upgrade-kube-vip-e27734
branch
from
August 21, 2026 12:42
6890892 to
ce913b0
Compare
kube-vip v0.9.2 pulls in a much larger transitive dependency tree (netlink, conntrack, dhcp, opentelemetry, ...) than v0.5.5, adding real compile time to `make build-host-agent-deb` on a cold Go build cache. main was already passing test-packaging at 273s against a 300s (-timeout 5m) budget before this bump, so the added compile time pushed a cold CI run over the edge (test timed out mid-build, no assertion failure). Bump to 10m for headroom; the suite itself still finishes in under 3 minutes with a warm cache. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drop the insomniacslk/dhcp replace directive (added for kube-vip 0.5.1) and upgrade kube-vip to v0.9.2, a stable release with modern dependencies.