fix(main): Make Ctrl+C actually work: Do not use context.TODO in setup controllers - #222
Merged
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
indradhanush
force-pushed
the
dg/context-todo-main
branch
from
August 20, 2026 20:14
537f679 to
14f0e3a
Compare
sebastian-pf9
changed the title
sebastian-pf9
approved these changes
Aug 21, 2026
Today with context.TODO, controllers will not cleanly exit when the parent context of the manager is canceled. Instead pass parent's ctx. More follow up work required to remove context.TODO() from rest of the codebase. This is a bigger change so an isolated PR is important. Also, refactor main so that we can unit test it.
indradhanush
force-pushed
the
dg/context-todo-main
branch
from
August 21, 2026 10:36
14f0e3a to
1afb117
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Today with context.TODO, controllers will not cleanly exit when the
parent context of the manager is canceled. Instead pass parent's ctx.
More follow up work required to remove context.TODO() from rest of the
codebase.
This is a bigger change so an isolated PR is important.
Also, refactor main so that we can unit test it.