test(e2e): extract shared packaging install-test helpers - #236
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
deb_install_test.go and rpm_install_test.go each hand-rolled the same container-boot-and-wait, byohctl/EnvironmentFile/is-enabled assertions, and removal-check loop. Any change to that shared lifecycle had to be hand-copied into both files to stay in sync. Move it into packaging_helpers_test.go so it exists once. Deb and rpm stay as separate specs rather than one parameterized test: they target different OS families (Ubuntu vs Rocky) and package managers, with genuinely asymmetric steps (deb's architecture-tag and uninstall-log checks, rpm's stale-build-dir cleanup) — collapsing them further would trade real differences for a smaller diff. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Move copyFileToContainer/execInContainer into packaging_helpers_test.go alongside the rest of the shared helpers, instead of leaving them in rpm_install_test.go despite deb_install_test.go already calling them cross-file. Restore the "by dpkg -r"/"by rpm -e" qualifier in assertPathsRemoved's failure message that got dropped when the removal-check loop was extracted, so a failure still says what uninstall step should have removed the path. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
sebastian-pf9
force-pushed
the
claude/pict-matrix-rebase-68a6b1
branch
from
August 21, 2026 14:45
3fa95f6 to
740c890
Compare
indradhanush
approved these changes
Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
avoid code duplication