feat(byohctl): enable publishing byohctl binary to S3 - #247
Open
indradhanush wants to merge 1 commit into
Open
Conversation
…ilding Now that we build and publish artifacts from GitHub CI, we only need Teamcity to be able to fetch the byohctl binary given a specific version for internal use. As a result, track the teamcity specific script in the repo itself, so all the build does is invoke this with the appropriate args. Note: The teamcity build needs to be updated to use this script once this is merged.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
snslk
approved these changes
Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that we build and publish artifacts from GitHub CI, we only need Teamcity to be able to fetch the byohctl binary given a specific version for internal use.
As a result, track the teamcity specific script in the repo itself, so all the build does is invoke this with the appropriate args.
Note: The teamcity build needs to be updated to use this script once this is merged.