KAAP-656: Allowing users of type <name>@<domain>.<tld> to patch byohost objects

[vaibhavd21]

Fixes https://platform9.atlassian.net/browse/KAAP-656

Summary by Bito

This PR enhances byohost webhook logic to properly handle email-like usernames by implementing a precompiled regex pattern for validation. The changes improve user identification during the admission process, allowing email-format usernames to be properly processed. This update addresses the issue reported in the related ticket.

Unit tests added: False

Estimated effort to review (1-5, lower is better): 1

[bito-code-review]

Code Review Agent Run #5ec63f

Actionable Suggestions - 0

Additional Suggestions - 1

• apis/infrastructure/v1beta1/byohost_webhook.go - 1

  • Redundant email validation with conflicting logic flow · Line 62-65

Review Details

• Files reviewed - 1 · Commit Range: cafc828..cafc828

  • apis/infrastructure/v1beta1/byohost_webhook.go
• Files skipped - 0
• Tools

  • Whispers (Secret Scanner) - ✔︎ Successful
  • Detect-secrets (Secret Scanner) - ✔︎ Successful

---

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

• /review - Manually triggers a full AI review.

• /pause - Pauses automatic reviews on this pull request.

• /resume - Resumes automatic reviews.

• /resolve - Marks all Bito-posted review comments as resolved.

• /abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Default Agent You can customize the agent settings here or contact your Bito workspace admin at [email protected].

Documentation & Help

• Customize agent settings
• Review rules
• General documentation
• FAQ

AI Code Review powered by

[bito-code-review]

Changelist by Bito

This pull request implements the following key changes.

Key Change	Files Impacted
Feature Improvement - Enhancements to Email Username Handling	- byohost_webhook.go - Introduced a precompiled regex for email-like usernames and added a new check in the admission webhook to allow users with email-formatted names.

[cruizen]

LGTM.

Nitpick: Can we add data-driven unit tests to show example patterns that match and a few that don't?