KAAP-519: Download kubelet, kubectl and cri-tools binaries from k8s / cri repo not APT #74
Conversation
… curl and add in bundle
Changelist by BitoThis pull request implements the following key changes.
|
![bito-code-review[bot]](https://avatars.githubusercontent.com/in/1061978?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review Agent Run #42a020
Actionable Suggestions - 1
-
installer/bundle_builder/ingredients/deb/download.sh - 1
- Double 'v' prefix in CNI_VERSION variable · Line 17-19
Review Details
-
Files reviewed - 3 · Commit Range:
581dddc..581dddc- installer/bundle_builder/build-bundle.sh
- installer/bundle_builder/ingredients/deb/Dockerfile
- installer/bundle_builder/ingredients/deb/download.sh
-
Files skipped - 0
-
Tools
- Whispers (Secret Scanner) - ✔︎ Successful
- Detect-secrets (Secret Scanner) - ✔︎ Successful
Bito Usage Guide
Commands
Type the following command in the pull request comment and save the comment.
-
/review- Manually triggers a full AI review. -
/pause- Pauses automatic reviews on this pull request. -
/resume- Resumes automatic reviews. -
/resolve- Marks all Bito-posted review comments as resolved. -
/abort- Cancels all in-progress reviews.
Refer to the documentation for additional commands.
Configuration
This repository uses Default Agent You can customize the agent settings here or contact your Bito workspace admin at [email protected].
Documentation & Help
AI Code Review powered by
| K8S_VERSION="v${KUBERNETES_VERSION%%-*}" | ||
| CRICTL_VERSION="v${CRITOOL_VERSION}" | ||
| CNI_VERSION="v${CNI_VERSION}" |
There was a problem hiding this comment.
The K8S_VERSION and CRICTL_VERSION variables are correctly prefixed with 'v', but CNI_VERSION is incorrectly prefixed with 'v' twice since the environment variable already includes the 'v' prefix. This will cause download failures for CNI plugins.
Code suggestion
Check the AI-generated fix before applying
@@ -17,7 +17,7 @@
+K8S_VERSION="v${KUBERNETES_VERSION%%-*}"
+CRICTL_VERSION="v${CRITOOL_VERSION}"
-+CNI_VERSION="v${CNI_VERSION}"
++CNI_VERSION="${CNI_VERSION}"
+mkdir -p /ingredients
Code Review Run #42a020
Should Bito avoid suggestions like this for future reviews? (Manage Rules)
- Yes, avoid them
hsri-pf9
requested review from
cruizen,
jayanth-tjvrr,
mridulgain,
srm6867 and
vaibhavd21
Code Review Agent Run #472fa5Actionable Suggestions - 0Review Details
Bito Usage GuideCommands Type the following command in the pull request comment and save the comment.
Refer to the documentation for additional commands. Configuration This repository uses Documentation & Help AI Code Review powered by |
1 participant
What this PR does / why we need it:
Changed the way of downloading kubelet, kubectl, kubeadm and cri-tools not from apt but directly downloading it from the repo via curl and adding them to the bundle.
Summary by Bito
This pull request transitions from apt-based package downloads to direct downloads from remote repositories, refining the bundle builder, Dockerfile, and download script. The changes improve command syntax, update environment variables, and implement curl for fetching binaries. The PR also corrects variable formatting, enhances docker run commands with additional environment variables, and explicitly sets CNI_VERSION in the Dockerfile for a more robust deployment process.