KAAP-492: added the curl commands to download the dependencies

[hsri-pf9]

What this PR does / why we need it:

KAAP-492

Added the curl commands in download.sh to download the dependencies without using apt.

Summary by Bito

This pull request enhances dependency management by adding a 'bundle-deps' Makefile target for streamlined extraction, updating build-bundle.sh to copy additional dependency files, and modifying download.sh to use curl-based downloads instead of some apt-get operations, improving reliability and control in the build pipeline.

[bito-code-review]

Changelist by Bito

This pull request implements the following key changes.

Key Change	Files Impacted
Feature Improvement - Enhanced Dependency Bundling	- Makefile - Updated bundling process with a new 'bundle-deps' target and added variables to extract and manage dependency .deb files. - build-bundle.sh - Added commands to copy dependency .deb files (socat, ethtool, ebtables, conntrack) to support the new bundling workflow.
New Feature - Added Curl-based Dependency Download	- download.sh - Introduced curl commands with specified URLs to download dependency .deb files, providing an alternative to apt-get.

[bito-code-review]

Code Review Agent Run #c22f48

Actionable Suggestions - 1

• installer/bundle_builder/ingredients/deb/download.sh - 1

  • Hardcoded architecture in package URLs · Line 35-38

Review Details

• Files reviewed - 3 · Commit Range: de6a365..de6a365

  • Makefile
  • installer/bundle_builder/build-bundle.sh
  • installer/bundle_builder/ingredients/deb/download.sh
• Files skipped - 0
• Tools

  • Whispers (Secret Scanner) - ✔︎ Successful
  • Detect-secrets (Secret Scanner) - ✔︎ Successful

---

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

• /review - Manually triggers a full AI review.

• /pause - Pauses automatic reviews on this pull request.

• /resume - Resumes automatic reviews.

• /resolve - Marks all Bito-posted review comments as resolved.

• /abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Default Agent You can customize the agent settings here or contact your Bito workspace admin at [email protected].

Documentation & Help

• Customize agent settings
• Review rules
• General documentation
• FAQ

AI Code Review powered by

[bito-code-review]

Hardcoded architecture in package URLs

Hardcoded URLs for specific amd64 packages don't respect the $ARCH variable used elsewhere in the script. This will cause issues when building for architectures other than amd64.

Code suggestion

Check the AI-generated fix before applying

Suggested change

	SOCAT_URL="https://archive.ubuntu.com/ubuntu/pool/main/s/socat/socat_1.7.3.3-2_amd64.deb"
	ETHTOOL_URL="https://archive.ubuntu.com/ubuntu/pool/main/e/ethtool/ethtool_5.4-1_amd64.deb"
	EBTABLES_URL="https://archive.ubuntu.com/ubuntu/pool/main/e/ebtables/ebtables_2.0.10.4-3.4ubuntu1_amd64.deb"
	CONNTRACK_URL="https://archive.ubuntu.com/ubuntu/pool/main/c/conntrack-tools/conntrack_1.4.5-2_amd64.deb"
	SOCAT_URL="https://archive.ubuntu.com/ubuntu/pool/main/s/socat/socat_1.7.3.3-2_${ARCH}.deb"
	ETHTOOL_URL="https://archive.ubuntu.com/ubuntu/pool/main/e/ethtool/ethtool_5.4-1_${ARCH}.deb"
	EBTABLES_URL="https://archive.ubuntu.com/ubuntu/pool/main/e/ebtables/ebtables_2.0.10.4-3.4ubuntu1_${ARCH}.deb"
	CONNTRACK_URL="https://archive.ubuntu.com/ubuntu/pool/main/c/conntrack-tools/conntrack_1.4.5-2_${ARCH}.deb"

Code Review Run #c22f48

---

Should Bito avoid suggestions like this for future reviews? (Manage Rules)

• Yes, avoid them