dg/predictable agent versioning - #18
Merged
Merged
Conversation
indradhanush
commented
Jul 16, 2026
indradhanush
commented
Collaborator
- fix(agent): Do not cleanup uninstallation secret (fix(agent): Do not cleanup uninstallation secret cluster-api-provider-bringyourownhost#135)
- update byoh agent version in byohctl (update byoh agent version in byohctl cluster-api-provider-bringyourownhost#137)
- fix(webhook): Skip host ownership check (fix(webhook): Skip host ownership check cluster-api-provider-bringyourownhost#136)
- chore: Update CLAUDE.md (chore: Update CLAUDE.md cluster-api-provider-bringyourownhost#138)
- build(byohctl): derive VERSION from git describe
- feat(byohctl): resolve agent bundle URL from byohctl's own version
- build(ci): compute agent deb bundle version from git describe
- ci: publish agent deb bundle on every push to main
- build: add make tag as the single source of truth for agent versioning
- build(byohctl,ci): derive version from the shared make tag target
- build: use 8-char abbreviated commit sha in git describe
- ci: simplify Print tag step to just make tag
- feat(ci): publish controller-manager image on every push to main
- ci: skip draft PRs, re-run on ready-for-review, publish on PR push
- fix(ci): pass --no-print-directory to make -C tag invocations
GNU Make automatically enables --print-directory whenever -C is used, printing
'make: Entering directory' and 'Leaving directory' messages. This repo's dev
Mac ships an ancient GNU Make 3.81 that does not do this, but the GitHub
Actions Ubuntu runner's newer Make (4.x) does.
In .ci/build-push-controller.sh, IMAGE_TAG=$(make -C "${project_root}" tag)
captured that chatter into IMAGE_TAG via command substitution, corrupting the
docker build -t argument and failing the controller-manager publish workflow.
The same latent bug existed in cmd/byohctl/Makefile's VERSION assignment, just
not yet triggered since byohctl had only been built locally with the old Make.
Fixed both by passing --no-print-directory to make -C. Also added a fail-loud
whitespace guard on IMAGE_TAG in the controller script so this class of bug
cannot silently corrupt a docker tag again.
Verified: reproduced the failure locally with GNU Make 4.4.1, confirmed
--no-print-directory fixes it, and re-verified go build, go test, and shell
linting all pass.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.