feat(identity): group, group_membership, and group data source - #27
Merged
Conversation
Close the identity api-docs coverage gap:
- pcd_identity_group: resource (name/description/domain_id) + data source
(lookup by id or name). A first-class Keystone object that role assignments
and group membership can target.
- pcd_identity_group_membership: models a single user↔group pair, mapping
directly to PUT/DELETE /groups/{id}/users/{user_id} (simpler and more
composable than the upstream authoritative-set variant); Read uses
IsMemberOfGroup to detect out-of-band removal; composite <group_id>/<user_id>
import.
Includes examples, self-contained acceptance tests (Keystone needs no backend),
CHANGELOG, and generated docs. Adversarial review: 0 findings.
PF9-pushkar
added a commit
that referenced
this pull request
Jul 14, 2026
feat(identity): group, group_membership, and group data source
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes the identity gap the api-docs audit found —
groupswas the highest-value missing Keystone object.pcd_identity_group— resource (name / description / domain_id, domain_id ForceNew) + data source (lookup by id or name), matching the project/user/role pattern.pcd_identity_group_membership— one user↔group pair per resource, mapping directly toPUT/DELETE /groups/{id}/users/{user_id}. Chosen over upstream's authoritative-users-set variant because it's simpler and composable (no read-modify-write set, no authoritative-vs-additive footgun).ReadusesIsMemberOfGroupto drop the resource if the membership is removed out of band; composite<group_id>/<user_id>import.Adversarial review (state-consistency + gophercloud/membership lenses, each verified against source) returned 0 findings — including confirmation that
AddToGroup/RemoveFromGroup/IsMemberOfGroupare called with the correct(groupID, userID)arg order.Testing: build / vet / gofmt / golangci-lint (0) / unit tests / terraform fmt / docs generate — all clean. Acceptance tests are self-contained (Keystone needs no backend), so they can validate whenever the campaign resumes.
Part of the api-docs coverage build-out. Remaining: Cluster Blueprint and Kubernetes (both new REST-client families).